Jetpack: remove excessive hooks from social logos and genericons #39564
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
jetpack_register_social_logos()
andjetpack_register_genericons
is called directly, and the files are loaded onwp_loaded
after theinit
hook has already run.Hooking them into
init
has no effect on self-hosted, and we added separate hooks for WPCOM in D162597-code.Other information:
Jetpack product discussion
https://github.com/Automattic/vulcan/issues/529
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
id='genericons-css'
is loaded./wp-admin/options-general.php?page=sharing
, check the source code and confirm the stylesheetid='social-logos-css'
is loaded.