Remove/connection nudges where not needed

[CodeyGuyDylan]

There are several places on the Jetpack Dashboard and within Jetpack Settings that either:

1. Ask for a user connection when it is not required
2. Does not ask for a user connection when it is required

Proposed changes:

• Remove connection nudge from Akismet on the Dashboard and Settings
• Add connection nudge to Blaze when the reason it's disabled is only the missing user connection
• Remove connection nudge for Scan on the Dashboard
• Remove connection nudge for Brute Force Detection on Dashboard
• Remove user connection nudge from Search on Dashboard
  • User connection is required to access the Search Dashboard, but search can work without a user connection and we don't ask for it in settings if the site has a Search plan. I think we should keep that consistent on the dashboard

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

P2: pbNhbs-bHl-p2#comment-23715

Does this pull request change what data or activity we track or use?

No

Testing instructions:

NOTE: When looking at the code, pay close attention to the Blaze changes. The way the connection nudge was shown wasn't working so I had to go change some stuff on the Blaze backend. As far as I can tell, the stuff I changed was only used in the Settings of the frontend where this PR is updating. I had to edit a few instances where the should_initialize function was used, so it should work fine

1. Checkout this branch via the Jetpack Beta plugin or your local dev environment
2. Connect the site without connecting your user account
3. Go to /wp-admin/admin.php?page=jetpack#/dashboard
4. Ensure the Scan and Akismet card do not ask for a user connection and make sure the cards work as expected (try links and CTAs)
   
5. Ensure the Brute Force protection card does not ask for user connection
   
6. In the Performance and Growth section, ensure that only the AI and VideoPress card ask for a user connection
   
7. Now go to /wp-admin/admin.php?page=jetpack#/security and ensure the Akismet card does not ask for a user connection
   
8. Go to /wp-admin/admin.php?page=jetpack#/performance and ensure the Search module does not ask for user connection
   
9. Go to /wp-admin/admin.php?page=jetpack#/traffic and ensure the Blaze card asks for a user connection
   
10. Connect your user account and ensure all the cards looked at previously look good still
    
    
    
    
    

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the remove/connection-nudges-where-not-needed branch.

  • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack remove/connection-nudges-where-not-needed
  

  bin/jetpack-downloader test jetpack-mu-wpcom-plugin remove/connection-nudges-where-not-needed
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• 🔴 Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Choose a review path based on your changes:
   • A. Team Review: add the "[Status] Needs Team Review" label
     • For most changes, including minor cross-team impacts.
     • Example: Updating a team-specific component or a small change to a shared library.
   • B. Crew Review: add the "[Status] Needs Review" label
     • For significant changes to core functionality.
     • Example: Major updates to a shared library or complex features.
   • C. Both: Start with Team, then request Crew
     • For complex changes or when you need extra confidence.
     • Example: Refactor affecting multiple systems.
3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

---

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

• WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
• WoA releases happen weekly.
• Releases to self-hosted sites happen monthly. The next release is scheduled for October 1, 2024 (scheduled code freeze on September 30, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[IanRamosC]

Changes test as expected and code looks reasonable 👍🏾