Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix throwing a generic error when an HTTP error occurred #46

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Fix throwing a generic error when an HTTP error occurred #46

merged 1 commit into from
Jun 11, 2024

Conversation

dilirity
Copy link
Member

@dilirity dilirity commented May 31, 2024 •
edited
Loading

When there's a non 200 status code, the playwright browser interface throws a generic error.

This fixes things by throwing an HttpError.

@dilirity dilirity self-assigned this May 31, 2024
@dilirity dilirity requested review from pyronaur, haqadn and donnchawp June 3, 2024 09:44
@dilirity dilirity added the bug Something isn't working label Jun 3, 2024
@dilirity dilirity marked this pull request as ready for review June 3, 2024 09:44
haqadn
haqadn approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@haqadn haqadn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@dilirity dilirity merged commit 3cd063b into trunk Jun 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haqadn haqadn haqadn approved these changes

@pyronaur pyronaur Awaiting requested review from pyronaur

@donnchawp donnchawp Awaiting requested review from donnchawp

Assignees

@dilirity dilirity

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dilirity @haqadn