Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node 20 incompatibility #42

Merged
merged 4 commits into from
Oct 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
"error",
{ "args": "after-used", "argsIgnorePattern": "^_" }
],
"no-useless-constructor": "off"
"no-useless-constructor": "off",
"jsdoc/newline-after-description": "off"
}
}
2 changes: 1 addition & 1 deletion .github/workflows/jest-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v1
with:
node-version: "18"
node-version: "20"

- name: Install Dependencies
run: npm ci
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v1
with:
node-version: "18"
node-version: "20"

- name: Install Dependencies
run: npm ci
Expand Down
71 changes: 41 additions & 30 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "jetpack-boost-critical-css-gen",
"main": "./lib/index.js",
"description": "Critical CSS Generator capable of running in-browser (iframes) or on server-side (NodeJS + playwright). Built for use with Jetpack Boost.",
"version": "0.0.9",
"version": "0.0.10",
"license": "GPL-2.0-or-later",
"type": "module",
"scripts": {
Expand Down Expand Up @@ -58,6 +58,6 @@
"npm": "^8.18.0"
},
"overrides": {
"eslint-plugin-jsdoc": "^39.6.8"
"eslint-plugin-jsdoc": "^46.8.2"
}
}
2 changes: 1 addition & 1 deletion src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ export { generateCriticalCSS } from './generate-critical-css';

export * from './errors';

export const version = '0.0.9';
export const version = '0.0.10';
2 changes: 1 addition & 1 deletion src/style-ast.ts
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ export class StyleAST {
* Remove any selectors not listed in the criticalSelectors set, deleting any
* rules that no longer have any selectors in their prelude.
*
* @param criticalSelector
* @param criticalSelector
*/
pruneNonCriticalSelectors( criticalSelector: Set< string > ): void {
csstree.walk( this.ast, {
Expand Down
Loading