Update successUrlsThreshold calculation formula

Automattic · Jun 16, 2023 · 2731e57 · 2731e57
1 parent 66dd5aa
commit 2731e57
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/generate-critical-css.ts b/src/generate-critical-css.ts
@@ -153,7 +153,9 @@ export async function generateCriticalCSS( {
 	successRatio?: number;
 	maxPages?: number;
 } ): Promise< [ string, Error[] ] > {
-	const successUrlsThreshold = Math.ceil( urls.length * successRatio );
+	// Success threshold is calculated based on the success ratio of "the number of URLs provided", or "maxPages" whichever is lower.
+	// See 268-gh-Automattic/boost-cloud
+	const successUrlsThreshold = Math.ceil( Math.min( urls.length, maxPages ) * successRatio );
 
 	try {
 		progressCallback = progressCallback || noop;