Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PHP warning when in Utils::mb_parse_url() #137

Merged

Conversation

Nikschavan
Copy link
Contributor

This pull request includes a minor change to the includes/class-utils.php file to handle potential null values when parsing URLs.

  • includes/class-utils.php: Added a null check for $parts after calling wp_parse_url to ensure the function returns null if $parts is null.

Fixes - #136

To avoid PHP warnings when the output goes throughurldecode
@GaryJones GaryJones merged commit 32fc3eb into Automattic:develop Sep 30, 2024
2 checks passed
@GaryJones GaryJones added this to the 1.4.0 milestone Sep 30, 2024
@Nikschavan Nikschavan deleted the fix/136-dont-urldecode-null branch October 1, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants