QuickEditor: Missing action on gravatar icon

[mlumeau]

Closes #376

Description

Adds a redirection to https://gravatar.com/profile in a custom browser tab when clicking on the bottomsheet's Gravatar icon in the top right corner.

edit: launches in a regular browser tab to align with the behavior of the "view profile" button.

Testing Steps

• While logged out of Gravatar in your browser, click on the icon and see that you are redirected to the login page
• While logged in Gravatar in your browser, click on the icon and see that you are redirected to your profile edition page

[wpmobilebot]

📲 You can test the changes from this Pull Request in Gravatar Demo by scanning the QR code below to install the corresponding build.

	App Name	Gravatar Demo
	Commit	6050124
	Direct Download	gravatar-demo-prototype-build-pr400-6050124.apk

[AdamGrzybkowski]

Adds a redirection to https://gravatar.com/profile in a custom browser

I don't think the current code will use the custom browser tab. It will launch the browser. Launcing the custom tab looks more or less like this:

val customTabIntent: CustomTabsIntent = CustomTabsIntent.Builder()
        .build()
customTabIntent.launchUrl(context, URL)

I've also left a comment in the Issue on how to show the specific profile rather /profile. This could show the wrong profile if the user is logged in with a different email then used in the QE.

[AdamGrzybkowski]

Suggested change

	internal fun QETopBar(onDoneClick: () -> Unit, gravatarIconUrl: String, modifier: Modifier = Modifier) {
	internal fun QETopBar(onDoneClick: () -> Unit, onGravatarIconClick: () -> Unit = {}, modifier: Modifier = Modifier) {

I would expose the onGravatarIconClick rather than pass the URL to let the parent composable decide what behavior they want on icon tap. I think it's more flexible, WDYT?

[mlumeau]

Fixed in 187258d

[mlumeau]

I don't think the current code will use the custom browser tab

You're right, I had that in mind but then decided to go with a regular tab in the code to do the same as the "view profile" button, forgot to change that in the PR description.

[hamorillo]

I've also left a comment in the Issue on how to show the specific profile rather /profile. This could show the wrong profile if the user is logged in with a different email then used in the QE.

This is important. I think we'll need to "launch" the callback at least to GravatarQuickEditorBottomSheet and, from there, open the profile using the email from gravatarQuickEditorParams.

[mlumeau]

This is important. I think we'll need to "launch" the callback at least to GravatarQuickEditorBottomSheet and, from there, open the profile using the email from gravatarQuickEditorParams

In that case if the email is not associated to a gravatar account it will 404. That's what I did in my first commit. Also if the user is signed in a different email there will be an error message in the bottom sheet after oauth, so I think it's enough.

[AdamGrzybkowski]

If you think that's a better URL to open I think it's best to discuss with iOS folks to make sure both platforms are aligned.

[AdamGrzybkowski]

[mlumeau]

Permission to merge into the release branch? They're targeting this release on iOS.