Proguard rules for :gravatar module #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamGrzybkowski
force-pushed
the
adam/345_rules
branch
from
0095991
to
649321d
Compare
AdamGrzybkowski
commented
Oct 7, 2024
| isMinifyEnabled = false | ||
| isMinifyEnabled = true | ||
| isShrinkResources = true | ||
| signingConfig = signingConfigs.findByName("debug") |
There was a problem hiding this comment.
Not sure we want it like that, but it's nice for testing and we don't use it for anything else right now.
📲 You can test the changes from this Pull Request in Gravatar Demo by scanning the QR code below to install the corresponding build.
|
AdamGrzybkowski
force-pushed
the
adam/345_rules
branch
from
649321d
to
fb30f9e
Compare
hamorillo
approved these changes
Oct 8, 2024
Yeah we should do it. #361 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #345
Description
This PR provides pro guard rules that will be shipped with our SDK so that our code won't crash if
isMinifyEnabledin third-party app is enabled.Testing Steps
Run the demo app with the release build type and try to test each tab. Ideally, test
trunkfirst to confirm there was an issue (crash).