Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final UI Tweaks #1106

Merged
merged 2 commits into from
Aug 24, 2024
Merged

Final UI Tweaks #1106

merged 2 commits into from
Aug 24, 2024

Conversation

LucaHaverty
Copy link
Collaborator

Small UI tweaks and polish to improve the overall look and user experience

  • Changed modal spacing to look closer to a panel

Before

Screenshot 2024-08-22 103244

After

Screenshot 2024-08-22 103805

Panel for reference

Screenshot 2024-08-22 103306

  • Removed settings that aren't yet implemented (camera controls and useMetric)
  • Fixed some panel icons that were too small
  • When a scheme is deleted that's bound to a robot, unbind it and set the robot to "not configured"
  • Always show the close button on the choose scheme panel

@LucaHaverty LucaHaverty requested review from HunterBarclay and a team as code owners August 22, 2024 18:09
@LucaHaverty LucaHaverty requested review from a-crowell and Dhruv-0-Arora and removed request for a team August 22, 2024 18:09
@LucaHaverty LucaHaverty self-assigned this Aug 22, 2024
@LucaHaverty LucaHaverty changed the title Small modal spacing tweaks and control scheme deletion fix Final UI Tweaks Aug 22, 2024
@BrandonPacewic BrandonPacewic self-requested a review August 22, 2024 19:01
@BrandonPacewic BrandonPacewic added the ui/ux Relating to user interface, or in general, user experience label Aug 22, 2024
BrandonPacewic
BrandonPacewic approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it 😸

Dhruv-0-Arora
Dhruv-0-Arora requested changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@Dhruv-0-Arora Dhruv-0-Arora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The width sizing has made it look a little weird on mobile.

Screenshot 2024-08-22 at 6 20 30 PM

Can we also add panel, modal, and mainHUD sizing tweaks in this PR to make everything fit for mobile devices?

Dhruv-0-Arora
Dhruv-0-Arora approved these changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@Dhruv-0-Arora Dhruv-0-Arora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marvelous 🍪

Lets do the UI scaling for mobile devices in another PR

@HunterBarclay HunterBarclay merged commit a1b9e7a into dev Aug 24, 2024
14 checks passed
@HunterBarclay HunterBarclay deleted the haverty/final-ui-tweaks branch August 24, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dhruv-0-Arora Dhruv-0-Arora Dhruv-0-Arora approved these changes

@BrandonPacewic BrandonPacewic BrandonPacewic approved these changes

@HunterBarclay HunterBarclay Awaiting requested review from HunterBarclay HunterBarclay is a code owner

@a-crowell a-crowell Awaiting requested review from a-crowell a-crowell is a code owner automatically assigned from Autodesk/fission

Assignees

@LucaHaverty LucaHaverty

Labels
ui/ux Relating to user interface, or in general, user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LucaHaverty @BrandonPacewic @Dhruv-0-Arora @HunterBarclay