Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch When No Design is Selected #1099

Merged
merged 3 commits into from
Aug 21, 2024
Merged

Catch When No Design is Selected #1099

merged 3 commits into from
Aug 21, 2024

Conversation

azaleacolburn
Copy link
Member

@azaleacolburn azaleacolburn commented Aug 20, 2024 •
edited
Loading

Description

Add catch and messagebox when no design is open in the exporter.

JIRA Issue

@azaleacolburn azaleacolburn changed the base branch from prod to dev August 20, 2024 17:02
@azaleacolburn azaleacolburn marked this pull request as ready for review August 20, 2024 17:21
@azaleacolburn azaleacolburn requested review from HunterBarclay and a team as code owners August 20, 2024 17:21
@azaleacolburn azaleacolburn requested review from PepperLola and BrandonPacewic and removed request for a team August 20, 2024 17:21
@azaleacolburn azaleacolburn self-assigned this Aug 20, 2024
PepperLola
PepperLola approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@PepperLola PepperLola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me 🚘

BrandonPacewic
BrandonPacewic approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛻

@BrandonPacewic BrandonPacewic merged commit 1e72d60 into dev Aug 21, 2024
14 checks passed
@BrandonPacewic BrandonPacewic deleted the colbura/1851/catch-no-robot branch August 21, 2024 21:57
@BrandonPacewic BrandonPacewic mentioned this pull request Aug 22, 2024
Open
BrandonPacewic added a commit that referenced this pull request Aug 23, 2024
@BrandonPacewic
Expanded fix from GH-1099
a3685b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrandonPacewic BrandonPacewic BrandonPacewic approved these changes

@PepperLola PepperLola PepperLola approved these changes

@HunterBarclay HunterBarclay Awaiting requested review from HunterBarclay HunterBarclay is a code owner

Assignees

@azaleacolburn azaleacolburn

Labels
exporter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@azaleacolburn @PepperLola @BrandonPacewic