Move subsystem config to the combined configuration panel #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucaHaverty
requested review from
a-crowell and
Dhruv-0-Arora
and removed request for
a team
a-crowell
requested changes
Aug 20, 2024
There was a problem hiding this comment.
I like how you made each joint separate and moved inversion to each one. That makes a lot of sense.
However, the combination with the intake and ejector isn't very intuitive. It makes me realize Joints or Motors might be a better term for the joints because the armavator is the intake/ejector subsystem. This could look like intake/ejector being lumped into Gamepiece Manipulation > (Intake / Ejector) && Subsystems (Drivetrain / Arm / Elevator) or something like Intake && Ejector && Joints.
Having the inversion out makes the Sequential Joints much more intuitive too! Great work.
BrandonPacewic
added
the
refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added all of the subsystem config functionality to the combined configuration panel.
Warning
Merge after #1089
JIRA Issue