Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mirabuf Friction Parsing #1096

Open
wants to merge 35 commits into
base: dev
Choose a base branch
from
Open

Mirabuf Friction Parsing #1096

wants to merge 35 commits into from

Conversation

azaleacolburn
Copy link
Member

@azaleacolburn azaleacolburn commented Aug 16, 2024 •
edited by BrandonPacewic
Loading

Description

Parsing mirabuf object friction on the fission end.

Objectives

  • Allow fission to use friction values packaged in assemblies by the exporter
  • Refactor anything icky i find in the way fission handles mirabuf

Testing Done

  • Make sure all mirabuf functions still work normally
  • Test friction overrides of extreme values in fission - @BrandonPacewic

JIRA Issue

@azaleacolburn azaleacolburn changed the base branch from prod to dev August 16, 2024 17:09
@azaleacolburn azaleacolburn added physics Relating to either the underlying physics engine or the usage of it mirabuf Relating to the mirabuf format refactor The most important part of software development. labels Aug 16, 2024
@azaleacolburn azaleacolburn self-assigned this Aug 16, 2024
@azaleacolburn azaleacolburn changed the title Mirabuf Friction Parsing + Parsing Refactor Mirabuf Friction Parsing Aug 19, 2024
@azaleacolburn azaleacolburn marked this pull request as ready for review August 19, 2024 20:59
@azaleacolburn azaleacolburn requested review from HunterBarclay and a team as code owners August 19, 2024 20:59
@azaleacolburn azaleacolburn requested review from a-crowell and Dhruv-0-Arora and removed request for a team August 19, 2024 20:59
@BrandonPacewic BrandonPacewic self-requested a review August 20, 2024 16:36
@BrandonPacewic BrandonPacewic requested review from PepperLola and removed request for Dhruv-0-Arora August 20, 2024 20:46
BrandonPacewic
BrandonPacewic reviewed Aug 20, 2024
View reviewed changes
Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some equality unit test failed for some reason.

BrandonPacewic
BrandonPacewic requested changes Aug 22, 2024
View reviewed changes
Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry to say that the issue is still not fixed. Additionally dozer seems to be a void of all light.

Screen.Recording.2024-08-22.at.09.57.23.mov

PepperLola
PepperLola approved these changes Aug 24, 2024
View reviewed changes
Copy link
Member

@PepperLola PepperLola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dozer with lots of friction bounces weird and can't drive, which is what I would expect. ⛹️

HunterBarclay
HunterBarclay requested changes Sep 2, 2024
View reviewed changes
Copy link
Member

@HunterBarclay HunterBarclay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it is failing to cache robots, and they can't drive for me.

PepperLola
PepperLola requested changes Sep 4, 2024
View reviewed changes
Copy link
Member

@PepperLola PepperLola left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also can't drive the robots and this branch doesn't work on chromium, so it looks like at least a dev merge is in order once the fix is merged

@HunterBarclay HunterBarclay mentioned this pull request Sep 5, 2024
Open
@HunterBarclay HunterBarclay requested a review from a team as a code owner September 5, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PepperLola PepperLola PepperLola requested changes

@HunterBarclay HunterBarclay HunterBarclay requested changes

@a-crowell a-crowell Awaiting requested review from a-crowell a-crowell is a code owner automatically assigned from Autodesk/fission

@BrandonPacewic BrandonPacewic Awaiting requested review from BrandonPacewic

Requested changes must be addressed to merge this pull request.

Assignees

@azaleacolburn azaleacolburn

Labels
mirabuf Relating to the mirabuf format physics Relating to either the underlying physics engine or the usage of it refactor The most important part of software development.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@azaleacolburn @HunterBarclay @PepperLola @BrandonPacewic