Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quality Configuration #1070

Draft
wants to merge 14 commits into
base: dev
Choose a base branch
from
Draft

Quality Configuration #1070

wants to merge 14 commits into from

Conversation

Dhruv-0-Arora
Copy link
Collaborator

@Dhruv-0-Arora Dhruv-0-Arora commented Jul 31, 2024

Description

Creating a separate panel for users to configure the different graphics settings to either boost performance or enhance the graphics

JIRA Issue

@Dhruv-0-Arora Dhruv-0-Arora self-assigned this Aug 2, 2024
@Dhruv-0-Arora Dhruv-0-Arora marked this pull request as ready for review August 6, 2024 03:42
@Dhruv-0-Arora Dhruv-0-Arora requested review from HunterBarclay and a team as code owners August 6, 2024 03:42
@Dhruv-0-Arora Dhruv-0-Arora requested review from a-crowell and LucaHaverty and removed request for a team August 6, 2024 03:42
@Dhruv-0-Arora Dhruv-0-Arora marked this pull request as draft August 6, 2024 21:00
@LucaHaverty
Copy link
Collaborator

Hovering over the '?' icon causes a jittering behavior for me because it shifts the panel over slightly

@Dhruv-0-Arora Dhruv-0-Arora mentioned this pull request Aug 8, 2024
3 tasks
@LucaHaverty
Copy link
Collaborator

Is this PR waiting for something else to be merged in or on hold?

Copy link
Collaborator

@LucaHaverty LucaHaverty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like the vast majority of users won't know what things like "cascades" and "shadow map size" are, so in my opinion it would be better to have preset quality levels that we know are stable rather than give them control over all the specific settings with the potential of breaking something or ending up with crazy artifacts.

Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like the vast majority of users won't know what things like "cascades" and "shadow map size" are, so in my opinion it would be better to have preset quality levels that we know are stable rather than give them control over all the specific settings with the potential of breaking something or ending up with crazy artifacts.

I agree, but I do think we should eventually have both as an option. Similar to how most games give you low, medium, and high presets but still let you change whatever specific option you want. (At your own risk of course).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants