Skip to content

Commit

Permalink
Fixed Suspension and organized code with constants
Browse files Browse the repository at this point in the history
- made suspension a function of the radius to stop the robot from shifting when stationary
- potential issue: robot is now raised off the ground even more than before
  • Loading branch information
Dhruv-0-Arora committed Jun 25, 2024
1 parent e8aaeb4 commit 1031d57
Showing 1 changed file with 8 additions and 9 deletions.
17 changes: 8 additions & 9 deletions fission/src/systems/physics/PhysicsSystem.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,11 @@ const COUNT_OBJECT_LAYERS = 10
export const SIMULATION_PERIOD = 1.0 / 120.0
const STANDARD_SUB_STEPS = 3

// Friction constants
const FLOOR_FRICTION = 0.7;
const SUSPENSION_MIN_FACTOR = 0.1;
const SUSPENSION_MAX_FACTOR = 0.3;

/**
* The PhysicsSystem handles all Jolt Phyiscs interactions within Synthesis.
* This system can create physical representations of objects such as Robots,
Expand Down Expand Up @@ -68,7 +73,7 @@ class PhysicsSystem extends WorldSystem {
new THREE.Vector3(0.0, -2.0, 0.0),
undefined
)
ground.SetFriction(0.7);
ground.SetFriction(FLOOR_FRICTION);
this._joltBodyInterface.AddBody(ground.GetID(), JOLT.EActivation_Activate)
}

Expand Down Expand Up @@ -451,16 +456,10 @@ class PhysicsSystem extends WorldSystem {
wheelSettings.mMaxHandBrakeTorque = 0.0
wheelSettings.mRadius = radius * 1.05
wheelSettings.mWidth = 0.1
wheelSettings.mSuspensionMinLength = 0.0000003
wheelSettings.mSuspensionMaxLength = 0.0000006
wheelSettings.mSuspensionMinLength = radius * SUSPENSION_MIN_FACTOR
wheelSettings.mSuspensionMaxLength = radius * SUSPENSION_MAX_FACTOR
wheelSettings.mInertia = 1

// const friction = new JOLT.LinearCurve()
// friction.Clear()
// friction.AddPoint(1, 1)
// friction.AddPoint(0, 1)
// wheelSettings.mLongitudinalFriction = friction

const vehicleSettings = new JOLT.VehicleConstraintSettings()

vehicleSettings.mWheels.clear()
Expand Down

0 comments on commit 1031d57

Please sign in to comment.