Full OptiX Denoiser support #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also adds only_show_denoise functionality and rewrite of how the optix_filter is added to the display_driver
moved it from driver_process_bucket to the Init() funtion in driver_open this way the sample settings is only read once instead of every bucket
|
hey @JenusL i look forward to trying this out but i am soooo busy at work right now i can't find the time to compile and test. |
|
@caron no worries! Don't burn yourself out. |
Merged
|
@sjannuz Can we merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This took longer than expected but should conclude the Optix Denoiser support.
Workflow
As me and @caron discussed in #34 I've added a new Denoiser tab where I put all the OptiX Denoiser settings that affects the display driver.
I looked at MAXtoA when I implemented it but added some more things to it.
I cleaned up the old code a bit, and moved some of the progressbar code so it runs in
driver_openinstead of in each bucket.I added some convenience functions that I miss from python to CStringUtilites:
StartsWithandEndsWithOnly show denoise implementation details
I spent quite a lot of time on this one. At first I tried to just skip sending the non-denoised bucket to Softimage but then nothing updates. I tried a lot of thing until I settled on a workaround where I still send the non-denoised bucket to Softimage but with a size of 1 pixel. So while most of the image retained in the display is denoised, 1 pixel of each bucket in the next progressive pass is from the non-denoised image, until it's denoised again at the end of that pass. This is barely visible at all so it should be fine.
It passes the testsuite, closes #21 and closes #48
Oh... and let me know if you have any feedback and something should change before merging.