Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SItoA for Arnold 5.2 to master #29

Merged
merged 193 commits into from
Jan 29, 2019
Merged

SItoA for Arnold 5.2 to master #29

merged 193 commits into from
Jan 29, 2019

Conversation

JenusL
Copy link
Contributor

@JenusL JenusL commented Sep 4, 2018

I must say that it has been very fun to code for this project so far. The code is so nice and structured that it has been a breeze to navigate and read.
Now after #28 has been merged into develop I feel that it's time to merge this into master and make a real release. Or should we include something more?

Before we merge, lets discuss how we should deal with versioning and branching going forward.
I changed the versioning to match Arnold version because that just makes more sense to me. But that goes away from the old versioning. How do you guys feel?
Last version of SItoA was 4.1. Is it ok to jump to 5.2 and sync with the Arnold version or should we name this 4.2 and stick with the old versioning that's unrelated to Arnold version?

This goes together with branching a bit. If we should remove the develop branch and always PR to master, we would probably like to version up on every PR whether it's a new feature or a fix. That can end up being a lot of versions. I think that means someone at AD needs to be responsible for the versioning because it probably needs to be done as a separate commit directly to the branch after a batch of PRs has been merged.
What do you think?

@JenusL
Copy link
Contributor Author

JenusL commented Jan 17, 2019

@sjannuz When you have merged the remaining open PRs I feel it's time to go master. What do you think?

@sjannuz
Copy link
Contributor

sjannuz commented Jan 17, 2019

Hi @JenusL , sure, I just need a couple of hours to dedicate to this.
Thankyou again

@JenusL
Copy link
Contributor Author

JenusL commented Jan 28, 2019

@sjannuz @kikou Think u got time this week?

@sjannuz sjannuz merged commit 8b71c99 into master Jan 29, 2019
@JenusL
Copy link
Contributor Author

JenusL commented Jan 29, 2019

Thank you so much @sjannuz for taking the time to finally go master!
Do you think you can find the time to create a release with a xsiaddon for both Win and Linux as well?

@sjannuz
Copy link
Contributor

sjannuz commented Jan 30, 2019

Hi @JenusL , I should have some time before the end of this week. Thankyou for all your work.

@sjannuz
Copy link
Contributor

sjannuz commented Jan 31, 2019

52a0a4b:

  • Modified SConscript to install ArnoldDenoiser.py and all the linux dsos.
  • Upgraded the template custom py files to use Arnold 5.2.2.1.

@sjannuz
Copy link
Contributor

sjannuz commented Jan 31, 2019

I have the addons ready, built against 5.2.2.1. I've packed different addons for Windows and Linux, since each is now about 370M.
Any volunteer to test the Linux one ?

@JenusL
Copy link
Contributor Author

JenusL commented Jan 31, 2019

Awesome! I reached out to si-community to see if anyone can test on Linux. I will reach out to some friends tomorrow morning as well.

@JenusL
Copy link
Contributor Author

JenusL commented Jan 31, 2019

I wrote down a changelog as well if you want to use it for the release: https://gist.github.com/JenusL/a8ac760ebd867356035f5e2913990254

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants