Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove-constraints errors if no NOT VALIDS involved #626

Merged
merged 2 commits into from
Nov 26, 2024
Merged

fix: remove-constraints errors if no NOT VALIDS involved #626

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e66d3c3
fix: remove-constraints errors if no NOT VALIDS involved
vjeeva Nov 25, 2024
9ac62b1
Merge branch 'main' into vjeeva/remove-constraints-bug
vjeeva Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions pgbelt/util/dump.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,11 +310,14 @@ async def remove_dst_not_valid_constraints(
if (config.tables and table in config.tables) or not config.tables:
queries = queries + f"ALTER TABLE {table} DROP CONSTRAINT {constraint};"

command = ["psql", config.dst.owner_dsn, "-c", f"'{queries}'"]
if queries != "":
command = ["psql", config.dst.owner_dsn, "-c", f"'{queries}'"]

await _execute_subprocess(
command, "Finished removing NOT VALID constraints from the target.", logger
)
await _execute_subprocess(
command, "Finished removing NOT VALID constraints from the target.", logger
)
else:
logger.info("No NOT VALID detected for removal.")


async def apply_target_constraints(config: DbupgradeConfig, logger: Logger) -> None:
Expand Down