Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove useless command (dump_constraints for dst dump...) #625

Merged
merged 4 commits into from
Nov 26, 2024
Merged

fix: remove useless command (dump_constraints for dst dump...) #625

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
20cef65
fix: remove useless command (dump_constraints for dst dump...)
vjeeva Nov 19, 2024
0286b3c
fix: missed an unused import
vjeeva Nov 26, 2024
2a69199
fix: missed an unused import
vjeeva Nov 26, 2024
2a31bc3
Merge branch 'main' into vjeeva/cleanup-useless-commands
vjeeva Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions pgbelt/cmd/schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
from pgbelt.util.dump import apply_target_constraints
from pgbelt.util.dump import apply_target_schema
from pgbelt.util.dump import create_target_indexes
from pgbelt.util.dump import dump_dst_not_valid_constraints
from pgbelt.util.dump import dump_source_schema
from pgbelt.util.dump import dump_dst_create_index
from pgbelt.util.dump import remove_dst_not_valid_constraints
Expand Down Expand Up @@ -58,17 +57,6 @@ async def load_constraints(config_future: Awaitable[DbupgradeConfig]) -> None:
await apply_target_constraints(conf, logger)


@run_with_configs(skip_src=True)
async def dump_constraints(config_future: Awaitable[DbupgradeConfig]) -> None:
"""
Dumps the NOT VALID constraints from the target database onto disk, in
the schemas directory.
"""
conf = await config_future
logger = get_logger(conf.db, conf.dc, "schema.dst")
await dump_dst_not_valid_constraints(conf, logger)


@run_with_configs(skip_src=True)
async def remove_constraints(config_future: Awaitable[DbupgradeConfig]) -> None:
"""
Expand Down Expand Up @@ -134,7 +122,6 @@ async def create_indexes(config_future: Awaitable[DbupgradeConfig]) -> None:
dump_schema,
load_schema,
load_constraints,
dump_constraints,
remove_constraints,
dump_indexes,
remove_indexes,
Expand Down