fix: support for capital letters in sequence names #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vjeeva
changed the title
vjeeva
force-pushed
the
vjeeva/capital-bug-sequences
branch
from
2ded386 to
795ac1d
Compare
jdcallet
approved these changes
Sep 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Capitals in Sequence Names would yield errors like
relation "non_public_schema.users_id_seq" does not existfor a sequence nameduserS_id_seq. Previously we thought the integration test covered this but the schema SQL didn't wrap the sequence names in quotes.Solved it in this PR! Integration test works!