Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refactor Teardown Command due to DROP EXTENSION woes #326

Merged
merged 7 commits into from
Nov 20, 2023
Merged

feat: refactor Teardown Command due to DROP EXTENSION woes #326

merged 7 commits into from
Nov 20, 2023

Conversation

josephoyomiautodesk
Copy link
Contributor

@josephoyomiautodesk josephoyomiautodesk commented Nov 20, 2023 •
edited by vjeeva
Loading

Addresses #274

@josephoyomiautodesk josephoyomiautodesk changed the title pglogical.py and teardown.py revoke_pgl changes STOPS-4828: pglogical.py and teardown.py revoke_pgl changes Nov 20, 2023
@josephoyomiautodesk josephoyomiautodesk changed the title STOPS-4828: pglogical.py and teardown.py revoke_pgl changes STOPS-4828: [Pgbelt] Refactor Teardown Command due to DROP EXTENSION woes Nov 20, 2023
@vjeeva vjeeva changed the title STOPS-4828: [Pgbelt] Refactor Teardown Command due to DROP EXTENSION woes Refactor Teardown Command due to DROP EXTENSION woes Nov 20, 2023
vjeeva
vjeeva reviewed Nov 20, 2023
View reviewed changes
pgbelt/cmd/teardown.py Outdated Show resolved Hide resolved
vjeeva
vjeeva requested changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@vjeeva vjeeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@vjeeva vjeeva changed the title Refactor Teardown Command due to DROP EXTENSION woes feat: refactor Teardown Command due to DROP EXTENSION woes Nov 20, 2023
@josephoyomiautodesk josephoyomiautodesk merged commit 5de6300 into main Nov 20, 2023
10 checks passed
@josephoyomiautodesk josephoyomiautodesk deleted the STOPS-4828a branch November 20, 2023 21:32
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vjeeva vjeeva vjeeva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josephoyomiautodesk @vjeeva