Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Psi 4 integration #170

Open
wants to merge 158 commits into
base: psi4
Choose a base branch
from
Open

Psi 4 integration #170

wants to merge 158 commits into from

Conversation

obrien951
Copy link

Cumulative work on the MDT PSI4 interface. Be advised to find commits from multiple branches.
Handles optimizations, energies, one-electron properties, and plotting of normal mode displacement vectors.

avirshup and others added 30 commits February 7, 2017 19:51
# Conflicts:
#	moldesign/_tests/test_data_structures.py
#	moldesign/method.py
# Conflicts:
#	DockerMakefiles/Moldesign.yml
#	DockerMakefiles/NWChem.yml
#	moldesign/helpers/__init__.py
#	moldesign/molecules/notebook_display.py
#	moldesign/utils/__init__.py
#	moldesign/viewer/viewer3d.py
#	scripts/conda_deploy.sh
# Conflicts:
#	moldesign/_tests/test_mm.py
#	moldesign/interfaces/openbabel.py
#	moldesign/models/amber.py
#	moldesign/models/nwchem.py
#	moldesign/molecules/trajectory.py
#	moldesign/utils/__init__.py
#	moldesign/utils/classes.py
#	moldesign/utils/exportall.py
#	moldesign/utils/exports.py
#	moldesign/utils/exportutils.py
avirshup and others added 23 commits June 27, 2017 15:42
…"'dipole'" to be returned. Syntax for "'dipole'" collection will be changed.
…ith minimizing molecules using qm packages. The gradient will be assigned to the wavefunction using the constructor.

A minimize module was added to the Psi4Potential. It calls the qsi4.opt function and saves the trajectory. Other appropriate changes were made to the Psi4Potential to facilitate execuation of this function.

A function was added to the Psi4Model to save a Psi4 optimization history as a MDT minimization trajectory. The the module was added outside the Psi4Potential class to allow for a user-defined Psi4 optimization history to be added as a minimization trajectory.

The Psi4interface module was also changed to allow for a user defined psi4history to be added.
…nstead of a string.

The psi4_interface psi4_to_mdt function was written and now returns molecules.

Changes were made to the initiation of the multiplicity in the molecule class.

The Psi4 model was changed to accomodate charge and multiplicities from psi4 molecules. The interface was prepared to have a mdt wavefunction initiation function added later.
…ion was added to the psi4 model. The molecule class was prepared for addding molecular vibrations.
…calculations. These changes consisted of handling of units and data structuring of certain quantities.
…n a skeleton for saving normal mode displacements to atoms. The skeletal additions to the atoms will need to be reviewed and rendered functional.
@CLAassistant
Copy link

CLAassistant commented Jul 27, 2017

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 3 committers have signed the CLA.

✅ avirshup
❌ Joseph O'Brien
❌ obrien951


Joseph O'Brien seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@avirshup
Copy link
Contributor

Hey @obrien951 and @loriab - Huge apologies for not getting to this yet. @ktbolt and I are working through getting a working version of MDT 0.8 out into the wild, and this will be coming up shortly afterwards.

@loriab
Copy link

loriab commented Aug 30, 2017

I'm behind on this too. Good luck with MKL 0.8 prep.

@avirshup avirshup changed the title O'Brien Psi 4 integration Aug 31, 2017
@avirshup avirshup mentioned this pull request Aug 31, 2017
@avirshup
Copy link
Contributor

avirshup commented Sep 15, 2017

@obrien951 - I'm FINALLY taking a look at this. And it looks good! I'm making a few changes to update it for the most recent version of the code (mostly just changed import paths).

One more thing before it gets merged - can you agree to the contributor agreement here? It gives us permission to integrate the code into the project and manage it as part of the codebase.

@loriab
Copy link

loriab commented Nov 22, 2017

Hi Aaron, glad to see how much this has come along since I last checked the repo!

Sorry about the CLA. I watched Joe do the agreement process, but it must not have gone through. But I see now that you force pushed to master, perhaps, or something that has confounded this PR's history? Is the thing to do to start from a current master, cherry-pick over @obrien951's commits (should preserve author info), then submit a new PR, trying the CLA again?

An update on the Psi side, All of Joe's changes are at the bottom of psi4/psi4#834, which additionally makes a lot more vibrational analysis info available for your taking.

Look forward to seeing you next week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants