Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HYDRA-762 - Investigate why the tumbling performance of USD scene is slower than corresponding Maya Scene under Hydra Storm #91

Merged
merged 4 commits into from
Mar 6, 2024

Conversation

vlasovi
Copy link
Collaborator

@vlasovi vlasovi commented Mar 1, 2024

Fixing double-rendering of USD prims + autotest

@vlasovi vlasovi self-assigned this Mar 1, 2024
@vlasovi vlasovi requested a review from ppt-adsk March 1, 2024 15:07
@vlasovi
Copy link
Collaborator Author

vlasovi commented Mar 1, 2024

@lilike-adsk
Copy link
Collaborator

Nice catch! @vlasovi, I assume now, we can get similar fps on USD scene as corresponding Maya scene , right?

@vlasovi
Copy link
Collaborator Author

vlasovi commented Mar 1, 2024

Nice catch! @vlasovi, I assume now, we can get similar fps on USD scene as corresponding Maya scene , right?

Yes

@vlasovi vlasovi assigned vlasovi and unassigned vlasovi Mar 4, 2024
Copy link
Collaborator

@ppt-adsk ppt-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though I wouldn't tie the test to the scene browser.

void AdskHydraSceneBrowserTestFixture::VerifySceneCorrectness()
{
// Traverse prim hierarchy
QTreeWidgetItemIterator itPrimsTreeWidget = GetIteratorForTree(_primHierarchyWidget);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test, looks good, but it feels out of place to tie it to the scene browser. I asked @debloip-adsk and he agreed with me, saying that

with APIs like GetChildPrimPaths, GetPrim, Get methods for container data sources (or GetElement for vector data sources) + casts, and GetValue/GetTypeValue methods on data sources, the whole scene index scene hierarchy can be inspected.

Here's an example you might like:
https://github.com/Autodesk/maya-hydra/blob/dev/test/lib/mayaUsd/render/mayaToHydra/cpp/testPrimInstancing.cpp
It shouldn't change the logic of the test.

@vlasovi vlasovi assigned vlasovi and unassigned vlasovi Mar 6, 2024
@vlasovi vlasovi requested a review from ppt-adsk March 6, 2024 16:38
Copy link
Collaborator

@ppt-adsk ppt-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks for the test!

@vlasovi vlasovi added the ready-for-merge Development process is finished, PR is ready for merge label Mar 6, 2024
@roopavr-adsk roopavr-adsk added bug Something isn't working test labels Mar 6, 2024
@roopavr-adsk roopavr-adsk merged commit 4d608ba into dev Mar 6, 2024
10 checks passed
@roopavr-adsk roopavr-adsk deleted the vlasovi/HYDRA-762 branch March 6, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready-for-merge Development process is finished, PR is ready for merge test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants