-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HYDRA-738 : Add support for Maya's AntiAliasing toggle to affect Hydra's MSAA toggle #90
Closed
roopavr-adsk
wants to merge
21
commits into
dev
from
roopavr/HYDRA-738/supportHydraMSAAToggleFromMaya
Closed
HYDRA-738 : Add support for Maya's AntiAliasing toggle to affect Hydra's MSAA toggle #90
roopavr-adsk
wants to merge
21
commits into
dev
from
roopavr/HYDRA-738/supportHydraMSAAToggleFromMaya
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tests get affected
roopavr-adsk
deleted the
roopavr/HYDRA-738/supportHydraMSAAToggleFromMaya
branch
March 12, 2024 18:28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hook up Maya's AA settings to Hydra multisampling toggle.
Introducing this change cause many of our unit tests to fail as MSAA is off by default in Maya and Hydra has it on by default.
Unit test framework required changes that has MSAA enabled by default. This PR contains those changes.
Additionally, some reference images also needed to be updated. All these changes must go together the tests/builds to pass.