Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HYDRA-807 : Add Unit Test for Maya Display Modes #74

Merged
merged 12 commits into from
Feb 16, 2024

Conversation

roopavr-adsk
Copy link
Contributor

Tests Maya Display mode for:
Smooth Shade All
Use default material
wireframe on shaded
Textured
Use all Lights
Shadows

@roopavr-adsk roopavr-adsk self-assigned this Feb 14, 2024
Copy link
Collaborator

@lilike-adsk lilike-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can delete the ".mayaSwatches" folder, it seems to be useless

lilike-adsk
lilike-adsk previously approved these changes Feb 14, 2024
@roopavr-adsk roopavr-adsk removed their assignment Feb 16, 2024
@roopavr-adsk roopavr-adsk self-assigned this Feb 16, 2024
Copy link
Collaborator

@debloip-adsk debloip-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Added a small FYI, I'll let you decide if you want to adjust this test now or merge it as-is



def test_MayaDisplayModes(self):
cmds.file(new=True, force=True)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed this, but as an FYI, this is no longer necessary, as that command will now be run by default before each individual test (see mtohUtils.py). Shouldn't cause issues though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noted. will incorporate it in my next PR.

@roopavr-adsk roopavr-adsk merged commit 3475e45 into dev Feb 16, 2024
10 checks passed
@roopavr-adsk roopavr-adsk deleted the roopavr/HYDRA-807/mayaModeUnitTest branch February 16, 2024 21:43
@roopavr-adsk roopavr-adsk added ready-for-merge Development process is finished, PR is ready for merge test labels Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge Development process is finished, PR is ready for merge test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants