HYDRA-805 - add test for look through camera&lights #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| #Test look through camera and maya lights (spot & area). | ||
| def test_LookThrough(self): | ||
| cmds.file(new=True, force=True) |
There was a problem hiding this comment.
This is no longer necessary, as now a new scene will be opened before each individual test.
There was a problem hiding this comment.
good, I'll remove it
| @@ -112,9 +111,6 @@ createNode file -n "file1"; | |||
| setAttr ".cs" -type "string" "sRGB"; | |||
| createNode place2dTexture -n "place2dTexture1"; | |||
| rename -uid "6616C90D-4B36-08C7-8666-33BB13D15663"; | |||
| createNode mayaUsdLayerManager -n "mayaUsdLayerManager1"; | |||
| rename -uid "61CE7C31-4E04-09B7-BFEA-F291A58D7E4C"; | |||
| setAttr ".sst" -type "string" ""; | |||
There was a problem hiding this comment.
Are these changes required? Not sure why they're here, doesn't look like they're used
There was a problem hiding this comment.
This's just for clearing out mayausd stuff, this might cause loading of mayausd, which is not necessary for this case.
|
Thanks! Two minor things, otherwise looks good, just waiting to see if the changes in testStandardSurface.ma are okay to have in before approving |
debloip-adsk
approved these changes
Feb 15, 2024
lilike-adsk
added
test
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add test for look through camera&lights to cover
1.look through the camera
2.look through the spot light
3.look through the area light with clip planes