Update build.py to support MtoA artifactory download #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seando-adsk
requested changes
Feb 13, 2024
| @@ -500,7 +500,11 @@ def BuildAndInstall(context, buildArgs, stages): | |||
|
|
|||
| if context.mayaUsdLocation: | |||
| extraArgs.append('-DMAYAUSD_LOCATION="{mayaUsdLocation}"' | |||
| .format(mayaUsdLocation=context.mayaUsdLocation.replace("\\","/"))) | |||
| .format(mayaUsdLocation=context.mayaUsdLocation.replace("\\","/"))) | |||
There was a problem hiding this comment.
You should not need the replace here.
Comment on lines
+676
to
+677
| self.mtoaLocation = (os.path.abspath(args.mtoa_location) | ||
| if args.mtoa_location else None) |
There was a problem hiding this comment.
Add the replace here (like it is for mayaUsdLocation) above. Then these are sent to the BuildAndInstall and will have the / so no replace needed there.
|
Closing this PR as I cannot add another file to the PR. This PR was created while editing build.py in place on GitHub. |
roopavr-adsk
deleted the
roopavr/HYDRA-836/addMayaHydraMtoAPluginSupport
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.