Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HYDRA-814 : Use RootOverridesSceneIndex to simplify data producer scene indices #64

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

lanierd-adsk
Copy link
Collaborator

@lanierd-adsk lanierd-adsk commented Feb 9, 2024

Replace the complex scene index chain for dtat producer scene indices and USD stages scene indices by a UsdImagingRootOverridesSceneIndex.

…n for data producer scene indices (including Usd stages)
@lanierd-adsk lanierd-adsk self-assigned this Feb 9, 2024
@lanierd-adsk lanierd-adsk added the fvp-toolkit Flow Viewport Toolkit label Feb 9, 2024
@lanierd-adsk lanierd-adsk requested a review from ppt-adsk February 9, 2024 14:10
@lanierd-adsk
Copy link
Collaborator Author

Copy link
Collaborator

@ppt-adsk ppt-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I trust that existing tests are sufficient to cover your changes.

@lanierd-adsk
Copy link
Collaborator Author

Looks good to me! I trust that existing tests are sufficient to cover your changes.

Thanks. I did manual testing and also I had to fix some of the tests failing after this, so the tests seem relevant.

@lanierd-adsk lanierd-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Feb 12, 2024
@lanierd-adsk lanierd-adsk changed the title HYDRA-814 : Use RootOverridesSceneIndex to replace a scene index chai… HYDRA-814 : Use RootOverridesSceneIndex to simplify data producer scene indices Feb 12, 2024
@roopavr-adsk roopavr-adsk merged commit 4af9863 into dev Feb 12, 2024
11 checks passed
@roopavr-adsk roopavr-adsk deleted the lanierd/HYDRA-814 branch February 12, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fvp-toolkit Flow Viewport Toolkit ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants