Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HYDRA-795 - add test to cover arnold lights #56

Merged
merged 2 commits into from
Feb 5, 2024
Merged

HYDRA-795 - add test to cover arnold lights #56

merged 2 commits into from
Feb 5, 2024

Conversation

lilike-adsk
Copy link
Collaborator

Add test to cover arnold lights

Note: this test is skipped until Arnold plugin can be loaded in our test environment

@lilike-adsk lilike-adsk self-assigned this Feb 2, 2024
lanierd-adsk
lanierd-adsk requested changes Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@lanierd-adsk lanierd-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep the test alive and use
if (mayaUtils.loadPlugin("mtoa"))
to skip it if mtoa cannot be loaded.

test/lib/mayaUsd/render/mayaToHydra/testArnoldLights.py Show resolved Hide resolved
test/lib/mayaUsd/render/mayaToHydra/CMakeLists.txt Outdated Show resolved Hide resolved
@lilike-adsk lilike-adsk added test ready-for-merge Development process is finished, PR is ready for merge labels Feb 5, 2024
@lilike-adsk lilike-adsk merged commit 574aa01 into dev Feb 5, 2024
10 checks passed
@lilike-adsk lilike-adsk deleted the lilike/HYDRA-795/add-test-for-arnold-lights branch February 5, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lanierd-adsk lanierd-adsk lanierd-adsk approved these changes

Assignees

@lilike-adsk lilike-adsk

Labels
ready-for-merge Development process is finished, PR is ready for merge test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lilike-adsk @lanierd-adsk