Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HYDRA-786 - make sure skydome light is not turned off unexpectedly #41

Merged
merged 1 commit into from
Jan 19, 2024
Merged

HYDRA-786 - make sure skydome light is not turned off unexpectedly #41

merged 1 commit into from
Jan 19, 2024

Conversation

lilike-adsk
Copy link
Collaborator

@lilike-adsk lilike-adsk commented Jan 18, 2024 •
edited
Loading

Fix the dome light was turned off unexpectedly by 96a7223.

Note: there's another dome light issue logged as https://jira.autodesk.com/browse/HYDRA-794

@lilike-adsk
Copy link
Collaborator Author

FYI @debloip-adsk @roopavr-adsk @ppt-adsk

@lilike-adsk lilike-adsk self-assigned this Jan 18, 2024
ppt-adsk
ppt-adsk reviewed Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@ppt-adsk ppt-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to write a test for this? I would hope that the Hydra scene index graph would contain the needed information to write the test, no need to do image comparison.

@lilike-adsk
Copy link
Collaborator Author

Is there a way to write a test for this? I would hope that the Hydra scene index graph would contain the needed information to write the test, no need to do image comparison.

yes, will be done via another ticket https://jira.autodesk.com/browse/HYDRA-795, which is WIP. Want to merge this PR first :)

@lilike-adsk lilike-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Jan 19, 2024
@lilike-adsk lilike-adsk merged commit b9a7ba7 into dev Jan 19, 2024
10 checks passed
@lilike-adsk lilike-adsk deleted the lilike/HYDRA-786/fix-sky-dome-light branch January 19, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppt-adsk ppt-adsk ppt-adsk left review comments

@lanierd-adsk lanierd-adsk lanierd-adsk approved these changes

Assignees

@lilike-adsk lilike-adsk

Labels
ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lilike-adsk @ppt-adsk @lanierd-adsk