HYDRA-776 : Update build doc & script #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersions prerequisites
debloip-adsk
commented
Jan 10, 2024
| @@ -106,8 +112,6 @@ message(STATUS " PYTHON_INCLUDE_DIRS = ${PYTHON_INCLUDE_DIRS}") | |||
| message(STATUS " PYTHON_LIBRARIES = ${PYTHON_LIBRARIES}") | |||
| message(STATUS " Python_EXECUTABLE = ${Python_EXECUTABLE}") | |||
|
|
|||
| include(cmake/jinja.cmake) | |||
There was a problem hiding this comment.
Jinja is no longer needed in MayaHydra
Comment on lines
-138
to
+164
| You then need to set the generator to ```Ninja``` and the ```CMAKE_MAKE_PROGRAM``` variable to the Ninja binary you downloaded. | ||
| You then need to set the generator to ```Ninja```. | ||
| ``` | ||
| python build.py --generator Ninja --build-args=-DCMAKE_MAKE_PROGRAM='path to ninja binary' | ||
| python build.py --generator Ninja |
There was a problem hiding this comment.
Specifying the CMAKE_MAKE_PROGRAM should not be necessary as CMake will figure out which one to use based on the generator. This option mostly seems to be used to force a specific "make" program.
Comment on lines
-186
to
-187
| Jinja2 3.1.2 | ||
| MarkupSafe 2.1.1 |
There was a problem hiding this comment.
These two are no longer relevant
lilike-adsk
approved these changes
Jan 11, 2024
debloip-adsk
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the build docs to (hopefully) contain all info that might be needed to build the plugin. It also contains a slight tweak to the top-level CMakeLists to automatically determine the default Python version to build with based on the Maya version : note that the Python version can still be manually specified with the same variable as before.