Fix testFlowViewportAPI image diff thresholds #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanierd-adsk
approved these changes
Dec 21, 2023
debloip-adsk
added
ready-for-merge
roopavr-adsk
deleted the
debloip/fix-testFlowViewportAPI-diff-thresholds
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests in testFlowViewportAPI were expecting renders that matched exactly 1:1 the reference images, but renders can vary slightly between GPUs, so there was a slight difference between the reference images and OSX renders. This PR adds in some small thresholds to accept slight differences between a render and its reference image.