Selection change functors now take scene index as argument. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppt-adsk
commented
Dec 13, 2023
| @@ -941,37 +941,38 @@ void MtohRenderOverride::SelectionChanged( | |||
| // reading the Maya selection must be done from the Maya selection | |||
| // changed callback, not the UFE selection changed callback. | |||
| using SnOp = Ufe::SelectionCompositeNotification::Op; | |||
| static auto appendSn = [this](const SnOp& op) { | |||
| _selectionSceneIndex->AddSelection(op.item->path()); | |||
There was a problem hiding this comment.
Capturing the selection scene index once, on creation of the static functor, is incorrect, as the selection scene index is destroyed and re-created. We were therefore calling member functions on a destroyed object, causing crashes.
lanierd-adsk
approved these changes
Dec 13, 2023
ppt-adsk
added
the
ready-for-merge
roopavr-adsk
deleted the
tremblp/HYDRA-722/fix_selection_change_functors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static functors were capturing the selection scene index once, on construction. This is incorrect, as the selection scene index is destroyed and re-created on switching Hydra renderers.