Selection highlighting, picking of MhFootPrint node, with test. #228
Conversation
|
|
||
| // Pick handler for the footprint node. | ||
|
|
||
| class FootPrintPickHandler : public MayaHydra::PickHandler { |
There was a problem hiding this comment.
Foot print node had no pick handler, picking did not work.
|
|
||
| //Add the callback when an attribute of this node changes | ||
| MObject obj = thisMObject(); | ||
| _cbAttributeChangedId = MNodeMessage::addAttributeChangedCallback(obj, attributeChangedCallback, ((void*)this)); | ||
|
|
||
| //Data producer scene index interface is used to add the retained scene index to all viewports with all render delegates | ||
| auto& dataProducerSceneIndexInterface = Fvp::DataProducerSceneIndexInterface::get(); | ||
| dataProducerSceneIndexInterface.addDataProducerSceneIndex(_retainedSceneIndex, noPrefix, (void*)&obj, FvpViewportAPITokens->allViewports,FvpViewportAPITokens->allRenderers); | ||
| dataProducerSceneIndexInterface.addDataProducerSceneIndex(_retainedSceneIndex, _pathPrefix, (void*)&obj); |
There was a problem hiding this comment.
Removed default arguments.
| @@ -552,19 +598,30 @@ void* MhFootPrint::creator() | |||
|
|
|||
| void MhFootPrint::addedToModelCb() | |||
| { | |||
| static const SdfPath noPrefix = SdfPath::AbsoluteRootPath(); | |||
| _pathPrefix = SdfPath(TfStringPrintf("/MhFootPrint_%p", this)); | |||
There was a problem hiding this comment.
Lack of path prefix meant that the prefix was the Hydra scene index root. Thus, when foot print node was selected, the Hydra scene index root was selected, and all its children received selection highlighting, which is the normal and correct way to highlight children of a selected prim. Unfortunately, this meant that the whole scene was selection highlighted... Fixed with a proper Hydra scene index prefix.
| @@ -108,3 +112,29 @@ TEST(TestHydraPrim, translation) | |||
| constexpr double epsilon{1e-7}; | |||
| ASSERT_TRUE(GfIsClose(primTranslation, expectedTranslation, epsilon)); | |||
| } | |||
|
|
|||
| TEST(TestHydraPrim, countPrims) | |||
There was a problem hiding this comment.
New utility to count Hydra scene index prims, given a regular expression.
| @@ -257,5 +259,38 @@ def test_Load(self): | |||
| #using imageVersion as the color is different for this image under usd 24.11+ | |||
| self.assertSnapshotClose("loadingFootPrintScene.png", self.IMAGE_DIFF_FAIL_THRESHOLD, self.IMAGE_DIFF_FAIL_PERCENT, self.imageVersion) | |||
|
|
|||
| # Test selection highlighting. When the footprint node is selected, only | |||
There was a problem hiding this comment.
Without the fixes for picking and selection highlighting, these two tests fail.
With the fixes, these two tests pass.
ppt-adsk
added
the
ready-for-merge
lilike-adsk
deleted the
tremblp/HYDRA-1323/fix_footPrintNode_picking_and_sel_highlighting
branch
No description provided.