HYDRA-600 : Add filtering scene index interface to flow viewport tool… #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppt-adsk
reviewed
Nov 30, 2023
There was a problem hiding this comment.
Mostly minor comments. My main concern is the visibility support that is attached to nodes. I understand the idea, but I wonder if all the design and workflow implications are there:
- It only supports Maya nodes. I wonder if using UFE services would have allowed us to support LookDevX or USD nodes as well.
- It seems to only consider the Dag node visibility attribute. However, since Dag nodes have inherited visibility (from their ancestors), visibility must be computed, and cannot be read from a single attribute.
- It doesn't consider other factors that influence visibility, such as isolate select and display layers.
- I wonder if we should also consider Maya DG (Dataflow Graph) nodes. They aren't in the 3D scene, and therefore don't have visibility, but they may be better suited for rendering control such as providing scene index parameters.
To be discussed.
...PI/perViewportSceneIndicesData/fvpViewportInformationAndSceneIndicesPerViewportDataManager.h
Outdated
Show resolved
Hide resolved
test/lib/mayaUsd/render/mayaToHydra/cpp/testFlowViewportAPIFilterPrims.cpp
Outdated
Show resolved
Hide resolved
test/lib/mayaUsd/render/mayaToHydra/cpp/testFlowViewportAPIFilterPrims.cpp
Outdated
Show resolved
Hide resolved
lib/flowViewport/API/perViewportSceneIndicesData/fvpFilteringSceneIndicesChainManager.h
Outdated
Show resolved
Hide resolved
lib/flowViewport/API/perViewportSceneIndicesData/fvpFilteringSceneIndexDataAbstractFactory.h
Show resolved
Hide resolved
lib/flowViewport/API/perViewportSceneIndicesData/fvpFilteringSceneIndicesChainManager.cpp
Outdated
Show resolved
Hide resolved
lib/flowViewport/API/perViewportSceneIndicesData/fvpFilteringSceneIndicesChainManager.cpp
Outdated
Show resolved
Hide resolved
lib/flowViewport/API/perViewportSceneIndicesData/fvpFilteringSceneIndexDataBase.h
Outdated
Show resolved
Hide resolved
ppt-adsk
requested changes
Nov 30, 2023
lib/mayaHydra/hydraExtensions/sceneIndex/mayaHydraMayaFilteringSceneIndexData.cpp
Show resolved
Hide resolved
lib/mayaHydra/hydraExtensions/sceneIndex/mayaHydraMayaFilteringSceneIndexData.cpp
Show resolved
Hide resolved
lib/flowViewport/API/perViewportSceneIndicesData/fvpFilteringSceneIndexDataAbstractFactory.h
Show resolved
Hide resolved
lib/flowViewport/API/perViewportSceneIndicesData/fvpFilteringSceneIndicesChainManager.cpp
Outdated
Show resolved
Hide resolved
…nAndSceneIndicesPerViewportData and add const where it was possible.
ppt-adsk
approved these changes
Dec 1, 2023
lanierd-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…kit.