Add support for display of VtArray<bool> to Hydra scene browser #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppt-adsk
commented
Oct 15, 2024
| @@ -92,6 +92,13 @@ foreach(SOURCE IN ITEMS ${SOURCES}) | |||
| set(SET_EXPANDED_REPLACEMENT "setExpanded\(true\);") | |||
| string(REGEX REPLACE "${SET_EXPANDED_REGEX}" "${SET_EXPANDED_REPLACEMENT}" FILE_CONTENTS "${FILE_CONTENTS}") | |||
|
|
|||
| # Patch in support for VtArray<bool>. Arbitrarily place it after support | |||
There was a problem hiding this comment.
Somewhat ugly to do this in a loop that goes over all files, but convenient.
debloip-adsk
approved these changes
Oct 15, 2024
ppt-adsk
added
the
ready-for-merge
I have just created HYDRA-1252. |
debloip-adsk
deleted the
tremblp/hydra_scene_browser_array_of_bool_support
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very useful to debug instancer masking.