HYDRA-456 : Add test for USD stage layer muting #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debloip-adsk
force-pushed
the
debloip/HYDRA-456/layer-muting-test
branch
from
370c474 to
37223cb
Compare
debloip-adsk
force-pushed
the
debloip/HYDRA-456/layer-muting-test
branch
from
37223cb to
097a804
Compare
ppt-adsk
previously approved these changes
Nov 23, 2023
| * | ||
| * @return True if the argument prim path's name matches the predicate's prim name, false otherwise. | ||
| */ | ||
| bool operator()(const HdSceneIndexBasePtr& sceneIndex, const SdfPath& primPath) { |
There was a problem hiding this comment.
sceneIndex argument is unused?
There was a problem hiding this comment.
Yes, as this class is to be used as a FindPrimPredicate, whose signature includes a SceneIndex. This was indeed not explained, so I've renamed the unused scene index variable to _, mentioned that it is unused and clarified why that is.
| cmds.mayaUsdLayerEditor(self.subLayer.identifier, edit=True, muteLayer=(isMuted, self.usdProxyShapeUfePathString)) | ||
|
|
||
| def setupUsdStage(self): | ||
| import maya.cmds as cmds |
There was a problem hiding this comment.
Nit-pick: importing maya.cmds twice, may as well factor it out.
There was a problem hiding this comment.
Thanks, that import was even already factored out at the top so those were useless.
ppt-adsk
approved these changes
Nov 24, 2023
debloip-adsk
added
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test for HYDRA-456/HYDRA-436 where muting a USD stage layer would not be reflected in the scene index hierarchy.