HYDRA-1036 : Refactor Repr Selector Scene Index to send Dirty Notification #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d of repeated Add/Removal of prims
ppt-adsk
requested changes
Jul 25, 2024
ppt-adsk
previously approved these changes
Jul 30, 2024
| SceneIndexNotificationsAccumulator notifsAccumulator(sceneIndices.front()); | ||
|
|
||
| // Set wireframeOnShaded mode | ||
| MString wireframeOnCmd = "select -cl; modelEditor -e -wireframeOnShaded 1 modelPanel4; refresh;"; |
There was a problem hiding this comment.
Bit of a nit-pick, and there's nothing really wrong with this, but you could have done the
select -cl; modelEditor -e -wireframeOnShaded 1 modelPanel4
(the Python equivalent of it) in testSceneIndexDirtying.py, and here used the C++ API:
Suggested change
| MString wireframeOnCmd = "select -cl; modelEditor -e -wireframeOnShaded 1 modelPanel4; refresh;"; | |
| M3dView view; | |
| M3dView::getM3dViewFromModelPanel(MString("modelPanel4"), view); | |
| view.refresh(/* all = */ true); |
…irtyingNotification
roopavr-adsk
deleted the
roopavr/HYDRA-1036/refactorReprSceneIndexForDirtyingNotification
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change avoids removal/addition of Hydra prims and instead allowing dirty notification being sent to Hydra.