HYDRA-889 - Create a unit test for the shaded display mode with a texture image file #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Chorus detected one or more security issues with this pull request. See the Checks tab for more details. As a reminder, please follow the secure code review process as part of the Secure Coding Non-Negotiable requirement. |
debloip-adsk
requested changes
Jul 22, 2024
| mayaUtils.openTestScene("testUVandUDIM", "testHDR.ma") | ||
| self.setHdStormRenderer() | ||
| cmds.refresh() | ||
| self.assertSnapshotClose("quads_with_HDR.png", 0.04, 0.2) |
There was a problem hiding this comment.
For consistency, I would suggest we either use and adjust the existing threshold constants, or if we use bespoke thresholds per-test as here, then we should have the other test follow the same structure as well and adjust its code to mirror this one
| @@ -0,0 +1,552 @@ | |||
| //Maya ASCII 2026ff01 scene | |||
There was a problem hiding this comment.
Year needs to be changed, Maya 2026 is not a released product
| //Name: testHDR.ma | ||
| //Last modified: Thu, Jul 18, 2024 02:05:49 PM | ||
| //Codeset: 1252 | ||
| requires maya "2026ff01"; |
There was a problem hiding this comment.
Year needs to be changed, Maya 2026 is not a released product
debloip-adsk
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.