Lanierd/hydra 311 #149
Lanierd/hydra 311 #149
Conversation
| MSelectionList list; | ||
| MObject node; | ||
|
|
||
| // Add the shader to the selection list | ||
| list.add("standardSurface1"); | ||
|
|
||
| // Get the shader as an MObject | ||
| list.getDependNode(0, node); |
There was a problem hiding this comment.
Nit-pick: isn't this just GetDependNodeFromNodeName("standardSurface1", node)?
There was a problem hiding this comment.
Ha sorry, I missed that function, I will use it now.
| @@ -1685,4 +1634,55 @@ bool MayaHydraSceneIndex::passNormalsToHydra() | |||
| return val; | |||
| } | |||
|
|
|||
| VtValue MayaHydraSceneIndex::_CreateDefaultMaterialFallback() | |||
| { | |||
| static const MColor kDefaultGrayColor = MColor(0.5f, 0.5f, 0.5f) * 0.8f; | |||
There was a problem hiding this comment.
Where does 0.8f come from?
There was a problem hiding this comment.
I don't know, it could be anything else, I guess I've picked it up from a maya shader, but that is arbitrary as this fallback shader should not be used.
| //Sdfpath of the maya default material | ||
| SdfPath GetDefaultMaterialPath() const{return _mayaDefaultMaterialPath;} | ||
|
|
||
| bool GetDefaultMaterialAlreadyCreated() const{return _defaultMaterialCreated;} |
There was a problem hiding this comment.
Accessor name is a bit wordy, I like following the name of the member variable DefaultMaterialCreated(), or if you really want IsDefaultMaterialAlreadyCreated()
| @@ -252,6 +258,9 @@ class MAYAHYDRALIB_API MayaHydraSceneIndex : public HdRetainedSceneIndex, public | |||
| /// Is using an environment variable to tell if we should pass normals to Hydra when using the render item and mesh adapters | |||
| static bool passNormalsToHydra(); | |||
|
|
|||
| ///Create the default material from the "standardsurface1" maya material or create a fallback material if it cannot be found | |||
There was a problem hiding this comment.
Seen this one in a few places, name of the default material is camelCase standardSurface1, not standardSurface1.
| HdPathDataSourceHandle bindingPathDS = binding.GetPath(); | ||
| if (bindingPathDS) { // If a mesh prim has no material( bindingPathDS is empty), apply anyway the default material | ||
| const SdfPath materialPath = bindingPathDS->GetTypedValue(0.0f); | ||
| auto foundExcludedMaterialPath = std::find( |
There was a problem hiding this comment.
What size is this _defaultMaterialExclusionList expected to be? We are looping over this for each prim. If the list size is small, it's fine, but otherwise we can consider using an std::set.
There was a problem hiding this comment.
There is only one at this time, do you think I should switch to a std::set now ?
There was a problem hiding this comment.
No, just add a comment mentioning this as a possibility if the defaultMaterialExclusionList becomes large.
Support default material switching in the maya hydra viewport through a scene index