HYDRA-1103 : Update face selection shader to behave as an unlit shader #147
Conversation
| VtValue(GfVec3f(faceSelectioncolor[0], faceSelectioncolor[1], faceSelectioncolor[2])*0.3f) }); | ||
|
|
||
| // Emissive (component selection highlighting material should be independent of scene lighting) | ||
| node.parameters.insert( |
There was a problem hiding this comment.
This will make the shader be visible when there is no lights, but I think the problem was also that it should not receive lighting at all, I don't think this resolves this problem, right ?
There was a problem hiding this comment.
The face selection should be visible even when there are no lights. Isn't that the required behavior? Selection highlighting should be independent of scene lighting. Maya VP2 face sel highlight is visible even when no scene lights are used(Lighting>Use No Lights)
There was a problem hiding this comment.
The 0.3 magic constant seems to appear in 3 places, lines 700, 705, and 707. Any reason for that choice? And why not factor it out?
There was a problem hiding this comment.
The magic constant is based on VP2's shader behavior. Good idea to factor it out.
|
FYI : @lilike @tremblp @debloip @vlasovi @debloip-adsk |
roopavr-adsk
added
bug
roopavr-adsk
deleted the
roopavr/HYDRA-1103/faceSelectionIndependentOfSceneLighting
branch
No description provided.