-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HYDRA-712 : Handle hierarchical transform & visibility changes for plugin nodes #141
HYDRA-712 : Handle hierarchical transform & visibility changes for plugin nodes #141
Conversation
…erarchical changes
…port hierarchical changes
…ers and filtering scene indices
…dices to have only one updating location
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this image being empty expected ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I had added a comment to that effect here : https://github.com/Autodesk/maya-hydra/pull/141/files/c137ac27c3bf7a6941ca4626ca31453e75c8eced#diff-c4607392b118ce011b62fa5a94e6681c03986cfed357b9e5730e30a13b0e6ad8R188
You can also see the USD timeSamples here : https://github.com/Autodesk/maya-hydra/pull/141/files#diff-95f4f83179fe4db8124f53cc94c72138c1edccf2939dda366e81979f3918c8baR29-R32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the cubes being semi-transparent expected ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh I hadn't even noticed they're transparent. But this seems expected, as the cubes' opacity is set to 0.8, see here :
https://github.com/Autodesk/maya-hydra/blob/dev/lib/flowViewport/API/samples/fvpDataProducerSceneIndexExample.h#L76
and here :
https://github.com/Autodesk/maya-hydra/blob/dev/lib/flowViewport/API/samples/fvpDataProducerSceneIndexExample.h#L105-L106
This is also visible in the scene index :
And the reference snapshots for testFlowViewportAPI also show semi-transparent opacity.
However, in that case what I can't explain is why the cubes are not transparent when in the actual viewport. So in that sense it seems that it is the viewport behaviour that is incorrect, and not the snapshots. I logged HYDRA-1097 to track that. Good observation!
No description provided.