Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HYDRA-712 : Handle hierarchical transform & visibility changes for plugin nodes #141

Merged

Conversation

debloip-adsk
Copy link
Collaborator

No description provided.

@debloip-adsk debloip-adsk self-assigned this Jun 26, 2024
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this image being empty expected ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the cubes being semi-transparent expected ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh I hadn't even noticed they're transparent. But this seems expected, as the cubes' opacity is set to 0.8, see here :
https://github.com/Autodesk/maya-hydra/blob/dev/lib/flowViewport/API/samples/fvpDataProducerSceneIndexExample.h#L76
and here :
https://github.com/Autodesk/maya-hydra/blob/dev/lib/flowViewport/API/samples/fvpDataProducerSceneIndexExample.h#L105-L106
This is also visible in the scene index :
image
And the reference snapshots for testFlowViewportAPI also show semi-transparent opacity.

However, in that case what I can't explain is why the cubes are not transparent when in the actual viewport. So in that sense it seems that it is the viewport behaviour that is incorrect, and not the snapshots. I logged HYDRA-1097 to track that. Good observation!

lanierd-adsk
lanierd-adsk previously approved these changes Jun 27, 2024
@debloip-adsk debloip-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Jun 27, 2024
@lilike-adsk lilike-adsk merged commit 1a0384c into dev Jul 4, 2024
10 checks passed
@lilike-adsk lilike-adsk deleted the debloip/HYDRA-712/hierarchical-properties-for-plugins branch July 4, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants