Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added code coverage crash workaround to prune textures scene index. #138

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Added code coverage crash workaround to prune textures scene index. #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c4c9d5
Added code coverage crash workaround to prune textures scene index.
ppt-adsk Jun 18, 2024
e46ce03
Fixed non-coverage build compilation error.
ppt-adsk Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions lib/flowViewport/sceneIndex/fvpPruneTexturesSceneIndex.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,8 @@ PruneTexturesSceneIndex::MarkTexturesDirty(bool isTextured)

PruneTexturesSceneIndex::PruneTexturesSceneIndex(
HdSceneIndexBaseRefPtr const &inputSceneIndex)
: HdMaterialFilteringSceneIndexBase(inputSceneIndex)
: HdMaterialFilteringSceneIndexBase(inputSceneIndex),
InputSceneIndexUtils(inputSceneIndex)
{
}

Expand All @@ -95,10 +96,10 @@ PruneTexturesSceneIndex::_DirtyAllPrims(
const HdDataSourceLocatorSet locators)
{
HdSceneIndexObserver::DirtiedPrimEntries entries;
for (const SdfPath &path : HdSceneIndexPrimView(_GetInputSceneIndex())) {
for (const SdfPath &path : HdSceneIndexPrimView(GetInputSceneIndex())) {
entries.push_back({path, locators});
}
_SendPrimsDirtied(entries);
}

} //end of namespace FVP_NS_DEF
} //end of namespace FVP_NS_DEF
3 changes: 3 additions & 0 deletions lib/flowViewport/sceneIndex/fvpPruneTexturesSceneIndex.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,11 @@ typedef PXR_NS::TfRefPtr<const PruneTexturesSceneIndex> PruneTexturesSceneIndexC

class PruneTexturesSceneIndex :
public PXR_NS::HdMaterialFilteringSceneIndexBase
, public Fvp::InputSceneIndexUtils<PruneTexturesSceneIndex>
{
public:
using PXR_NS::HdMaterialFilteringSceneIndexBase::_GetInputSceneIndex;

FVP_API
static PruneTexturesSceneIndexRefPtr New(
const PXR_NS::HdSceneIndexBaseRefPtr &inputScene);
Expand Down