HYDRA-1070 - add missing space in resource path for Mac/Linux #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppt-adsk
approved these changes
Jun 13, 2024
lilike-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing space in "resource" path for mayaHydra.mod on Mac/Linux, otherwise, the path of PXR_PLUGINPATH_NAME section won't be recognized correctly by Maya.
This bug leads a problematic case below when deploying mayaHydra cut seperately from mayaUSD,
1.When Maya is loading mayaHydra plugin, the mayaHydraLib from mayaHydra cut folder is loaded and some variables are initializaed and registered to usd (e.g., MAYAHYDRALIB_SCENE_INDEX) as it's a dependency of mayaHydra plugin.
2.When Maya is parsing the mayaHydra.mod and mayaUSD.mod, due to the bug, the path of mayaHydra registered usd plugins (MayaHydra_cut_folder/MayaHydra/lib/usd) inside mayaHydraLib couldn't be added to PXR_PLUGINPATH_NAME correctly, but the plugins path (MayaUSD_folder/MayaUSD/lib/usd) from mayaUSD.mod is added to PXR_PLUGINPATH_NAME correctly, which leads unexpected mayaHydraLib from mayaUSD folder is loaded again during the first calling of MayaHydraAdapterRegistry::LoadAllPlugin() after switch to Hydra Viewport, and introduced double initialization issue for some variables. Note this seems to be a legacy issue, but exposed recently by new USD version.
This also solved a legacy mysterious bug that can cause some error output msg like: // Error: Could not find plugin for 'MayaHydraLightAdapter', when mayaUSD cut (deployed without mayaHydra stuff) and mayaHydra cut seperately.