Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HYDRA-310 : Support wireframe and wire on shaded and support selection highlight with the right colors #118

Merged
merged 12 commits into from
May 6, 2024
Merged

HYDRA-310 : Support wireframe and wire on shaded and support selection highlight with the right colors #118

merged 12 commits into from
May 6, 2024

Conversation

lanierd-adsk
Copy link
Collaborator

…

@lanierd-adsk
HYDRA-310 : Support wireframe and wire on shaded and support selectio…
f8a1089 
…n highlight with the right colors (lead and active)
@lanierd-adsk lanierd-adsk self-assigned this Apr 18, 2024
@lanierd-adsk lanierd-adsk requested a review from ppt-adsk April 18, 2024 13:56
@lanierd-adsk
Copy link
Collaborator Author

FYI : @lilike-adsk @debloip-adsk @roopavr-adsk @vlasovi

ppt-adsk
ppt-adsk requested changes Apr 19, 2024
View reviewed changes
Copy link
Collaborator

@ppt-adsk ppt-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! I have some concerns about Maya selection highlighting concepts bleeding into the Flow Viewport Toolkit selection object and selection scene index, but you've done a fantastic job.

lib/flowViewport/selection/fvpSelection.h Outdated Show resolved Hide resolved
lib/flowViewport/selection/fvpSelection.h Outdated Show resolved Hide resolved
...ib/mayaUsd/render/mayaToHydra/DataProducerSelHighlightTest/Storm_BoundingBox_AllSelected.png Outdated Show resolved Hide resolved
lib/flowViewport/sceneIndex/fvpBBoxSceneIndex.h Outdated Show resolved Hide resolved
lib/flowViewport/sceneIndex/fvpWireframeSelectionHighlightSceneIndex.h Outdated Show resolved Hide resolved
lib/flowViewport/sceneIndex/fvpWireframeSelectionHighlightSceneIndex.cpp Show resolved Hide resolved
lib/flowViewport/sceneIndex/fvpSelectionSceneIndex.cpp Outdated Show resolved Hide resolved
test/lib/mayaUsd/render/mayaToHydra/testDataProducerSelHighlight.py Outdated Show resolved Hide resolved
lib/mayaHydra/mayaPlugin/renderOverride.cpp Outdated Show resolved Hide resolved
lib/mayaHydra/mayaPlugin/renderOverride.cpp Outdated Show resolved Hide resolved
@lanierd-adsk lanierd-adsk requested a review from ppt-adsk May 3, 2024 13:52
@lanierd-adsk lanierd-adsk changed the title HYDRA-310 : Support wireframe and wire on shaded and support selectin highlight with the right colors HYDRA-310 : Support wireframe and wire on shaded and support selection highlight with the right colors May 3, 2024
ppt-adsk
ppt-adsk requested changes May 3, 2024
View reviewed changes
Copy link
Collaborator

@ppt-adsk ppt-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good, thanks for the changes! There are still wireframe-related changes to the Fvp::SelectionSceneIndex; I was hoping we could remove those somehow and keep the SelectionSceneIndex unaware of how selection highlighting is done.

lib/flowViewport/selection/fvpSelection.h Outdated Show resolved Hide resolved
lib/flowViewport/selection/fvpSelection.cpp Outdated Show resolved Hide resolved
lib/mayaHydra/hydraExtensions/mhLeadObjectPathTracker.h Outdated Show resolved Hide resolved
lib/mayaHydra/hydraExtensions/mhLeadObjectPathTracker.h Outdated Show resolved Hide resolved
lib/mayaHydra/hydraExtensions/mhLeadObjectPathTracker.cpp Outdated Show resolved Hide resolved
lib/mayaHydra/hydraExtensions/mhWireframeColorInterfaceImp.cpp Outdated Show resolved Hide resolved
lib/flowViewport/sceneIndex/fvpBlockPrimRemovalPropagationSceneIndex.h Outdated Show resolved Hide resolved
lib/flowViewport/sceneIndex/fvpBlockPrimRemovalPropagationSceneIndex.h Outdated Show resolved Hide resolved
lib/flowViewport/sceneIndex/fvpBlockPrimRemovalPropagationSceneIndex.h Outdated Show resolved Hide resolved
lib/flowViewport/sceneIndex/fvpSelectionSceneIndex.cpp Outdated Show resolved Hide resolved
@lanierd-adsk lanierd-adsk requested a review from ppt-adsk May 6, 2024 14:24
@lanierd-adsk lanierd-adsk added the ready-for-merge Development process is finished, PR is ready for merge label May 6, 2024
@roopavr-adsk roopavr-adsk added the enhancement New feature or request label May 6, 2024
@roopavr-adsk roopavr-adsk merged commit 942adf4 into dev May 6, 2024
10 checks passed
@roopavr-adsk roopavr-adsk deleted the lanierd/HYDRA-310NEW branch May 6, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppt-adsk ppt-adsk ppt-adsk approved these changes

Assignees

@lanierd-adsk lanierd-adsk

Labels
enhancement New feature or request ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lanierd-adsk @ppt-adsk @roopavr-adsk