HYDRA-536 & HYDRA-537 : Background color and grid tests #112
Conversation
debloip-adsk
force-pushed
the
debloip/HYDRA-536/HYDRA-537/background-color-and-grid-tests
branch
from
7be617f to
c32e27c
Compare
| cmds.file(new=True, force=True) | ||
| mayaUtils.openNewScene() |
There was a problem hiding this comment.
In the discussion on the color management PR, we talked about relying on the saved scene settings; however some settings are application-level and not saved per-scene, and some tests don't load a scene but instead construct it programmatically. So to remedy this, the suggestion of an optional parameter seems to me like the simplest compromise. I also added an analogous mayaUtils.openNewScene function, which opens a new scene and applies the test settings, and which is called before each test in replacement of cmds.file(new...) here. This, way the test settings are applied before each test and each new empty scene opened, but if we load an existing scene, we can let the scene's settings take over.
Note that in the spirit of favoring saved scene settings, we could consider removing the option of applying test settings in mayaUtils.openTestScene, and always relying on the saved scene settings, however for that we'd need to do a pass on our scene files to update them with the correct settings, which I feel would be better suited for a different PR (potentially alongside making MSAA disabled by default).
There was a problem hiding this comment.
Also with regards to @lilike-adsk's comment on providing a way to override certain default settings or using a skip flag, I think a simpler way is that if a test really needs specific settings, it can override setUp method and set whatever settings it needs, which means we don't have to implement a specific mechanism for this.
| cmds.displayRGBColor('background', 0.5, 0, 0) | ||
| self.compareBackgroundColor("background_red.jpg") | ||
| cmds.displayRGBColor('background', 0, 0.5, 0) | ||
| self.compareBackgroundColor("background_green.jpg") | ||
| cmds.displayRGBColor('background', 0, 0, 0.5) | ||
| self.compareBackgroundColor("background_blue.jpg") | ||
|
|
||
| cmds.displayRGBColor('background', 0, 0, 0) | ||
| self.compareBackgroundColor("background_black.jpg") | ||
| cmds.displayRGBColor('background', 0.5, 0.5, 0.5) | ||
| self.compareBackgroundColor("background_gray.jpg") | ||
| cmds.displayRGBColor('background', 1, 1, 1) | ||
| self.compareBackgroundColor("background_white.jpg") |
There was a problem hiding this comment.
It seems like we must use .jpg for playblasts to render the background color, using .png always rendered the background as transparent.
| cmds.file(new=1, f=1) | ||
|
|
There was a problem hiding this comment.
This test hasn't been enabled in over a year; see the test CMakeLists. I updated it on principle in case we bring it back and based on how I think it should be updated, but I haven't actually run it.
| cmds.file(new=1, f=1) | ||
| mayaUtils.openNewScene() |
There was a problem hiding this comment.
This test hasn't been enabled in over a year; see the test CMakeLists. I updated it on principle in case we bring it back and based on how I think it should be updated, but I haven't actually run it.
| @@ -15,8 +15,6 @@ | |||
| # | |||
There was a problem hiding this comment.
Removed a bunch of settings changes that were happening under the hood and moved them to an optional step when opening scenes (except camera as that one was never used). I kept defaultRenderGlobals.imageFormat because this is set based on the extension of the file name being passed in.
| @@ -29,6 +29,7 @@ | |||
| pass | |||
|
|
|||
There was a problem hiding this comment.
Removed some unused methods, added openNewScene, and added applyTestSettings, which mostly applies the test settings that were previously in snapshot.
debloip-adsk
added
ready-for-merge
lilike-adsk
deleted the
debloip/HYDRA-536/HYDRA-537/background-color-and-grid-tests
branch
No description provided.