HYDRA-927 - Expose complexity settings in globalRenderSettings #106
Conversation
# Conflicts: # lib/mayaHydra/mayaPlugin/renderOverride.cpp
| @@ -39,6 +39,7 @@ struct MayaHydraParams | |||
| float motionSampleStart = 0; | |||
| float motionSampleEnd = 0; | |||
| bool displaySmoothMeshes = true; | |||
| int refineLevel = 0; | |||
There was a problem hiding this comment.
What about the refineLevel which is adapters, MayaHydraAdapter::GetDisplayStyle().refineLevel > 0)
Is what you do replaces this ? Or is this something else ?
There was a problem hiding this comment.
I assume the added one is the global refine level, while the one in DisplayStyle is per-primitive, but it's not enabled yet due to MRenderItem was already refined. HdsiLegacyDisplayStyleOverrideSceneIndex can be used to override the per-primitive one.
There was a problem hiding this comment.
As far as I understand MayaHydraAdapter is used only for Maya native prims. The new scene index is supposed to be used only for USD prims. I will add "addExcludedSceneRoot" to it in my next commit to exclude Maya prims
| @@ -945,6 +949,10 @@ void MtohRenderOverride::_CreateSceneIndicesChainAfterMergingSceneIndex() | |||
| _sceneIndexRegistry.reset(new MayaHydraSceneIndexRegistry(_renderIndexProxy)); | |||
| } | |||
|
|
|||
| // Add display style scene index | |||
| _lastFilteringSceneIndexBeforeCustomFiltering = _displayStyleSceneIndex = | |||
| HdsiLegacyDisplayStyleOverrideSceneIndex::New(_lastFilteringSceneIndexBeforeCustomFiltering); | |||
There was a problem hiding this comment.
Maybe worth checking the perf impact (switch to Hydra/First Frame) after introducing this SceneIndex. We expect, by default, with refine level is 0, the overhead should be trivial
There was a problem hiding this comment.
@lilike-adsk With refine level set to 0, I haven't noticed any performance impact of this change. The FPS maybe degraded with refine levels more than 0, but this is expected.
# Conflicts: # lib/mayaHydra/mayaPlugin/renderOverride.cpp
…bal refine level - Maya native prims are excluded from gloabl refine level - Also fixed a bug with WireframeSelectionHighlightSceneIndex where the function addExcludedSceneRoot was called with a wrong path
| auto wfSi = TfDynamic_cast<Fvp::WireframeSelectionHighlightSceneIndexRefPtr>(Fvp::WireframeSelectionHighlightSceneIndex::New(_lastFilteringSceneIndexBeforeCustomFiltering, _selection)); | ||
| wfSi->SetDisplayName("Flow Viewport Wireframe Selection Highlight Scene Index"); | ||
|
|
||
| // At time of writing, wireframe selection highlighting of Maya native data | ||
| // is done by Maya at render item creation time, so avoid double wireframe | ||
| // selection highlighting. | ||
| wfSi->addExcludedSceneRoot(_ID); |
There was a problem hiding this comment.
@ppt-adsk while debugging around I found that the call that you implemented to wfSi->addExcludedSceneRoot doesn't receive the proper path. In my case the exclude path was "/MayaHydraViewportRenderer/_MayaHydra_HdStormRendererPlugin_0000023A87F10B80" while all the Maya native primitives were at the path "/MayaHydraViewportRenderer/rprims" so essentially we were drawing the selection highlight two times for those. Here I fix the bug
There was a problem hiding this comment.
@vlasovi thanks for the fix! Can we better document what _ID is supposed to be used for? Also, /MayaHydraViewportRenderer is duplicated at line 566. Can we factor this out?
vlasovi
added
the
ready-for-merge
Implement global refinement level for USD primitives
Automated test for the feature