Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HYDRA-926 : Remove Maya Hydra Scene Producer wrapper #101

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

roopavr-adsk
Copy link
Contributor

@roopavr-adsk roopavr-adsk commented Mar 14, 2024

One less layer for MayaHydra to talk to Hydra. MayaHydra Scene Producer was a wrapper that was introduced as a way to handle both Scene Delegates(Hydra V1) and Scene Indices (V2) in MayaHydra with the option to switch between the two for handing over data to Hydra. We decided to eliminate Scene Delegate support since we believe that using Scene Indices is the way forward according to Pixar.

In one of the previous commits (#100 ) we removed all Scene Delegate related code. In this PR, we are removing the MayaHydra Scene Producer wrapper.

@roopavr-adsk roopavr-adsk self-assigned this Mar 14, 2024
@roopavr-adsk roopavr-adsk requested a review from ppt-adsk March 14, 2024 12:55
Copy link
Collaborator

@ppt-adsk ppt-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, only a few minor changes!

@roopavr-adsk roopavr-adsk added ready-for-merge Development process is finished, PR is ready for merge core Related to core plugin sceneindex Hydra Scene Index labels Mar 14, 2024
@roopavr-adsk roopavr-adsk merged commit f47384f into dev Mar 14, 2024
10 checks passed
@roopavr-adsk roopavr-adsk deleted the roopavr/HYDRA-926/removeSceneProducerWrapper branch March 14, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Related to core plugin ready-for-merge Development process is finished, PR is ready for merge sceneindex Hydra Scene Index
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants