Skip to content

Commit

Permalink
Addressed second round of review comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
ppt-adsk committed Nov 13, 2023
1 parent d248cbc commit 276e27a
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 6 deletions.
15 changes: 10 additions & 5 deletions doc/selectionHighlightingArchitecture.md
Original file line number Diff line number Diff line change
Expand Up @@ -237,19 +237,20 @@ graph BT;
ph1[Plugin highlighting 1]-->hm;
subgraph ph[Plugin highlighting]
ph2[Plugin highlighting 2]-->ph1;
roSn[/Read-only Selection/]-->ph1;
roSn-->ph2;
roSn[/Read-only Selection/]-.->ph1;
roSn-.->ph2;
end
sn[Selection scene index]-->ph2;
fvpm[Flow Viewport merge]-->sn;
snSi[Selection scene index]-->ph2;
fvpm[Flow Viewport merge]-->snSi;
subgraph pd[Plugin data]
p1[Plugin 1];
p2[Plugin 2];
end
fvpm-. Path .->p1;
p1-->fvpm;
p2-->fvpm;
sn1[/Selection/]-->sn;
snSi-. Path .->fvpm;
sn[/Selection/]-.->snSi;
```
The plugin data and plugin highlighting subtrees are where plugins add their
scene indices. The data scene index is required, and the highlighting scene
Expand Down Expand Up @@ -336,6 +337,10 @@ HdSingleInputFilteringSceneIndexBase <|-- WireframeSelectionHighlightSceneIndex
RenderIndexProxy *-- MergingSceneIndex : Owns
SelectionSceneIndex ..> MergingSceneIndex : Path
SelectionSceneIndex o-- Selection : Read / Write
WireframeSelectionHighlightSceneIndex o-- Selection : Read
```

## Algorithmic Complexity
Expand Down
2 changes: 1 addition & 1 deletion lib/flowViewport/selection/fvpSelection.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ using namespace Fvp;

class SelectionSchemaFullySelectedBuilder {
public:
SelectionSchemaFullySelectedBuilder() : _builder() {
SelectionSchemaFullySelectedBuilder() {
_builder.SetFullySelected(
HdRetainedTypedSampledDataSource<bool>::New(true));
}
Expand Down

0 comments on commit 276e27a

Please sign in to comment.