read Git client versions from audit log #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we read the versions from the haproxy log and used the originating IP address to distinguish machines/users. In a load balancer setup this IP address can be the same for all requests and consequently the number of users per version are not counted correctly. Fix this by using the audit log to count the Git versions. Also count the versions by user ID and not by IP address. see #184
pluehne
approved these changes
Jun 12, 2019
There was a problem hiding this comment.
Thanks, @larsxschneider! Seems indeed like a more accurate way to count the number of Git client versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we read the versions from the haproxy log and used the
originating IP address to distinguish machines/users. In a load balancer
setup this IP address can be the same for all requests and consequently
the number of users per version are not counted correctly.
Fix this by using the audit log to count the Git versions. Also count
the versions by user ID and not by IP address.
see #184