-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.5-rc merge #27
v1.5-rc merge #27
Conversation
ecs.go
Outdated
} | ||
|
||
allInitialTargetsGone := true | ||
for targetId, _ := range initialTargetIdState { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S1005: unnecessary assignment to the blank identifier
(at-me in a reply with help
or ignore
)
ecs.go
Outdated
break | ||
case WaitUntilPrimaryRolled: | ||
useValidateDeploymentFunc = validateDeployment | ||
break |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S1023: redundant break statement
(at-me in a reply with help
or ignore
)
ecs.go
Outdated
break | ||
case WaitUntilPrimaryRolled: | ||
useValidateDeploymentFunc = validateDeployment | ||
break |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gosimple: S1023: redundant break statement
(at-me in a reply with help
or ignore
)
ecs.go
Outdated
} | ||
|
||
allInitialTargetsGone := true | ||
for targetId, _ := range initialTargetIdState { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gosimple: S1005: unnecessary assignment to the blank identifier
(at-me in a reply with help
or ignore
)
Fixes #25